Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Argument Clinic: Group guides about default values #106872

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Docs: Argument Clinic: Group guides about default values #106872

merged 1 commit into from
Jul 18, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 18, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 18, 2023
@erlend-aasland
Copy link
Contributor Author

@ezio-melotti, what do you think of this? IMO, it makes sense to group these below the "default values" guide, but I'm not so sure about the three "subsubsection" titles. In any case, it feels weird to start the subsubs all with "How to".

ezio-melotti
ezio-melotti approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, since it helps differentiate the subsubsection from the other howto subsections.

@erlend-aasland
Copy link
Contributor Author

Thanks, Ezio!

@erlend-aasland erlend-aasland merged commit 505eede into python:main Jul 18, 2023
24 checks passed
@miss-islington

This comment was marked as outdated.

Sign in to view
@erlend-aasland erlend-aasland deleted the clinic-docs/move-symbolic-default-values branch July 18, 2023 22:46
@miss-islington

This comment was marked as outdated.

Sign in to view
@bedevere-bot
Copy link

GH-106873 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2023
@erlend-aasland @miss-islington
Docs: Argument Clinic: Group guides about default values (pythonGH-10…
e192a7a 
…6872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values
(cherry picked from commit 505eede)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jul 18, 2023
@miss-islington

This comment was marked as outdated.

Sign in to view
@bedevere-bot
Copy link

GH-106874 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2023
@erlend-aasland @miss-islington
Docs: Argument Clinic: Group guides about default values (pythonGH-10…
97b44d9 
…6872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values
(cherry picked from commit 505eede)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 18, 2023
@miss-islington @erlend-aasland
[3.11] Docs: Argument Clinic: Group guides about default values (GH-1…
0c47ed7 
…06872) (#106873)

Docs: Argument Clinic: Group guides about default values (GH-106872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values

(cherry picked from commit 505eede)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 18, 2023
@miss-islington @erlend-aasland
[3.12] Docs: Argument Clinic: Group guides about default values (GH-1…
0c106a9 
…06872) (#106874)

Docs: Argument Clinic: Group guides about default values (GH-106872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values

(cherry picked from commit 505eede)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland
Docs: Argument Clinic: Group guides about default values (python/cpyt…
2647a31 
…hon#106872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@erlend-aasland
Docs: Argument Clinic: Group guides about default values (python/cpyt…
4c56015 
…hon#106872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland
Docs: Argument Clinic: Group guides about default values (python/cpyt…
5122701 
…hon#106872)

Previous ToC layout (excerpt):

    - How to use symbolic default values
    ...
    - How to assign default values to parameter
      - How to use the ``NULL`` default value
      - How to use expressions as default values

New layout:

    - How to assign default values to parameter
      - The ``NULL`` default value
      - Symbolic default values
      - Expressions as default values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @bedevere-bot @ezio-melotti